-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: optimize share section and share tab logic #8001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR overhauls the sharing feature by refactoring both the share tab and shared section blocs into explicit event/state files with manual classes (replacing Freezed), renaming repository interfaces and implementations to “*Impl”, enhancing UI components (collapsible shared section, updated button styling), and aligning tests to the new structure. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LucasXu0 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
10ce39a
to
e64717b
Compare
Feature Preview
PR Checklist
Summary by Sourcery
Refactor share tab and shared section features: unify naming conventions, externalize event/state classes, update repository implementations, adopt new ghost-button design, add shared section toggle behavior, and align tests accordingly
New Features:
Enhancements:
Tests:
Chores: